Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration-ebpf: artifact dependency bpf-linker #676

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tamird
Copy link
Member

@tamird tamird commented Jul 18, 2023

See commit message.

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for aya-rs-docs ready!

Name Link
🔨 Latest commit d261880
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/654a57f7bf19360008ab57f6
😎 Deploy Preview https://deploy-preview-676--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tamird
Copy link
Member Author

tamird commented Jul 18, 2023

Drat. This breaks the workflows on stable because cargo refuses to read test/integration-ebpf/Cargo.toml which now contains artifact = ... even though we --ignore integration-ebpf on the command line.

I'm thinking about how to solve this.

@tamird tamird marked this pull request as draft July 18, 2023 20:29
@tamird tamird force-pushed the linker-bindep branch 2 times, most recently from 0918458 to 1de8a71 Compare July 18, 2023 21:40
@mergify mergify bot added the test A PR that improves test cases or CI label Sep 14, 2023
@mergify
Copy link

mergify bot commented Sep 14, 2023

@tamird, this pull request is now in conflict and requires a rebase.

@mergify mergify bot added the needs-rebase label Sep 14, 2023
- integration-ebpf: add artifact dependency on bpf-linker.
- integration-ebpf: remove manual rerun-if-changed=bpf-linker.
- integration-ebpf: make bpf-linker availble to rustc in build.rs.
- xtask: filter for test binaries now that the build also produces the
  bpf-linker binary.
- github: remove `cargo install bpf-linker`.
- integration-test: remove bpf-linker installation instructions.

Blockers:
- rust-lang/cargo#12385 (artifact = "bin"
  makes entire workspace nightly-only).
Copy link

mergify bot commented Nov 18, 2023

@tamird, this pull request is now in conflict and requires a rebase.

@mergify mergify bot added the needs-rebase label Nov 18, 2023
Copy link

mergify bot commented Feb 6, 2024

@tamird, this pull request is now in conflict and requires a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase test A PR that improves test cases or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant