Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace lo interface with dummy interface #561

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

murex971
Copy link

Fixes: #422

@netlify
Copy link

netlify bot commented Mar 29, 2023

Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 20391f2
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/6424c37de90a480008436fee
😎 Deploy Preview https://deploy-preview-561--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@murex971 murex971 changed the title eplace lo interface with dummy interface replace lo interface with dummy interface Mar 29, 2023
@murex971 murex971 marked this pull request as draft March 29, 2023 22:38
Fixes: aya-rs#422

Signed-off-by: murex971 <nupur202000@gmail.com>
@Tuetuopay
Copy link
Contributor

Hi!

Just to let you know, #527 contains another fix fo #422. It still keeps using loopbacks, but runs tests in dedicated namespaces. (See 9da1dfe)

Using loopbacks has advantages compared to dummy interfaces: they loop back the traffic. In other words, any packet transmitted on the loopback is recieved on the same loopback. This is very useful for testing, especially XDP which only works in rx.

To get the same feature level, you’d need veth pairs. However that’s another can of worms, as IP configuration is required, and configuration that does not conflicts with the host machine. You could use vrfs or netns, but it’s gonna be complicated.

So yeah, for the current tests where we don’t test at all by sending packets it’s fine. But as soon as tests start to do it, dummy won’t cut it.

@mergify mergify bot added the test A PR that improves test cases or CI label Sep 14, 2023
@mergify
Copy link

mergify bot commented Sep 14, 2023

@murex971, this pull request is now in conflict and requires a rebase.

@mergify mergify bot added the needs-rebase label Sep 14, 2023
Copy link

mergify bot commented Feb 6, 2024

@murex971, this pull request is now in conflict and requires a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase test A PR that improves test cases or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integration-tests: Don't use lo interface for XDP, create some veths instead
2 participants