ebpf: Call bpf_probe_read on *const T BTF arguments
#543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
It's necessary to call `bpf_probe_read` not only for pointers retrieved from `PtRegs`, but also from BTF arguments. `bpf_probe_read` might return an error, so the return type of `.arg()` methods in contexts handling BTF arguments changes from `T` to `Option<T>`. `None` is returned when `bpf_probe_read` call is not successful. Fixes: aya-rs#542
vadorovsky
force-pushed
the
fentry-bpf-probe-read
branch
from
487a8c5
to
f41be0b
Compare
|
@vadorovsky mind rebasing? |
mergify
bot
added
aya-bpf
|
@vadorovsky, this pull request is now in conflict and requires a rebase. |
|
@vadorovsky, this pull request is now in conflict and requires a rebase. |
|
LGTM. I think this should be merged. @vadorovsky mind rebasing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's necessary to call
bpf_probe_readnot only for pointers retrieved fromPtRegs, but also from BTF arguments.bpf_probe_readmight return an error, so the return type of.arg()methods in contexts handling BTF arguments changes fromSelftoOption<Self>.Noneis returned whenbpf_probe_readcall is not successful.Fixes: #542