Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration-tests: Don't use lo interface for XDP, create some veths instead #422

Open
vadorovsky opened this issue Oct 28, 2022 · 1 comment · May be fixed by #915 or #561
Open

integration-tests: Don't use lo interface for XDP, create some veths instead #422

vadorovsky opened this issue Oct 28, 2022 · 1 comment · May be fixed by #915 or #561
Labels
good first issue Good for newcomers help wanted Extra attention is needed test A PR that improves test cases or CI

Comments

@vadorovsky
Copy link
Member

Currently, integration tests are attaching XDP programs to lo inteface:

aya/test/integration-test/src/tests/load.rs

Line 24 in f3262e8

name_prog.attach("lo", XdpFlags::default())?;

That's not a good approach, it's too intrusive, especially if the test fails or if for some reason the XDP program doesn't get unloaded. lo, as well as any already existing NICs, shouldn't be touched.

To test XDP, we should rather create some new, fake veth interfaces, which then we remove after running a test. Such interfaces should be also safe to remove manually if anything goes wrong with cleaning up after the test.
@vadorovsky vadorovsky added help wanted Extra attention is needed good first issue Good for newcomers test A PR that improves test cases or CI labels Oct 28, 2022
@raffaelespazzoli raffaelespazzoli mentioned this issue Nov 5, 2022
Closed
@dave-tucker
Copy link
Member

Don't use veths, use dummy interfaces. ip link add dummy0 type dummy

murex971 added a commit to murex971/aya that referenced this issue Mar 29, 2023
@murex971
test: replace lo interface with dummy interface
2ae5f26 
Fixes: aya-rs#422

Signed-off-by: murex971 <nupur202000@gmail.com>
@murex971 murex971 linked a pull request Mar 29, 2023 that will close this issue
Draft
murex971 added a commit to murex971/aya that referenced this issue Mar 29, 2023
@murex971
test: replace lo interface with dummy interface
43df857 
Fixes: aya-rs#422

Signed-off-by: murex971 <nupur202000@gmail.com>
murex971 added a commit to murex971/aya that referenced this issue Mar 29, 2023
@murex971
test: replace lo interface with dummy interface
20391f2 
Fixes: aya-rs#422

Signed-off-by: murex971 <nupur202000@gmail.com>
@kevinji kevinji linked a pull request Mar 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed test A PR that improves test cases or CI
Projects
None yet
Milestone
No milestone
2 participants
@dave-tucker @vadorovsky