SnsTemplate provides functionality to validate topic existence (#1137) #1142
+50
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardikSinghBehl
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
github-actions
bot
added
the
type: documentation
|
Hey @hardikSinghBehl thanks on PR! Will take a deeper look tomorrow and come back to you |
MatejNedic
requested changes
May 1, 2024
|
done, @MatejNedic |
MatejNedic
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Implemented the method
boolean topicExists(String topicArn)inSnsTemplateto validate the existence of an SNS topic via an ARN.💡 Motivation and Context
Implementation for issue #1137
💚 How did you test it?
The functionality has been tested by writing integration tests for the new method.
📝 Checklist
🔮 Next steps