Add SQS module @SnsNotificationMessage batch messages support #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxjiang153
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
maxjiang153
force-pushed
the
gh-1129
branch
3 times, most recently
from
09ca31f
to
d1cdf70
Compare
github-actions
bot
added
the
type: documentation
|
@tomazfernandes I've added the doc description for this, please check it out. And if everything is okay, I'll rebase it into a single commit. |
docs/src/main/asciidoc/sqs.adoc
Outdated
|
|
||
| The @SnsNotificationMessage annotation can be used for both single and batch message processing. | ||
|
|
||
| For single message processing, you can use the @SnsNotificationMessage annotation as follows: |
There was a problem hiding this comment.
We avoid using you and and use a more formal tone instead.
So maybe something like the @SnsNotificationMessage annotation can be used as follows:?
docs/src/main/asciidoc/sqs.adoc
Outdated
| @@ -626,6 +631,16 @@ public void listen(@SnsNotificationMessage Pojo pojo) { | |||
| } | |||
| ---- | |||
|
|
|||
| For batch message processing, you can use the @SnsNotificationMessage annotation with a List<Pojo> parameter: | |||
There was a problem hiding this comment.
Same here about using you
There was a problem hiding this comment.
done, check it out again plz.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摙 Type of change
馃摐 Description
see: #1129
馃挕 Motivation and Context
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps