Add SQS QueueNotFoundStrategy auto-configure support.

[maxjiang153]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

By default, when using SQS, even if a queue doesn't exist or is mispelled, it will automatically create a new queue, and there are no autoconfiguration options supported for this feature. So add a new auto-configure option to control the behavior of this.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• I updated reference documentation to reflect the change
• All tests passing
• No breaking changes

🔮 Next steps

[tomazfernandes]

Cool PR @wmz7year!

Left one comment for your consideration, please let me know your thoughts.

Thanks.

[tomazfernandes]

Your approach is solid, but we already define the default in ContainerOptions.

I think we could be more defensive in this PR and not have a default set here, and instead only set these values to the Options objects if the user adds a value in the configuration.

Wdyt?

[maxjiang153]

Yes, ContainerOptions is a good way to do this, but there are two methods to use SQS component: the first one is 'SqsMessageListenerContainerFactory', and the second one is SqsTemplate.
If we only set QueueNotFoundStrategy on ContainerOptions, the SqsTemplate won't work.

And also about the default value, currently both SqsTemplate and SqsContainerOptions are defined as default QueueNotFoundStrategy to CREATE value. To avoid making a change about this, I keep the default value here.

Check these out:

spring-cloud-aws/spring-cloud-aws-sqs/src/main/java/io/awspring/cloud/sqs/operations/SqsTemplate.java

Line 632 in 0813661

private QueueNotFoundStrategy queueNotFoundStrategy = QueueNotFoundStrategy.CREATE;

spring-cloud-aws/spring-cloud-aws-sqs/src/main/java/io/awspring/cloud/sqs/listener/SqsContainerOptions.java

Line 128 in 0813661

private static final QueueNotFoundStrategy DEFAULT_QUEUE_NOT_FOUND_STRATEGY = QueueNotFoundStrategy.CREATE;

TBH, I think QueueNotFoundStrategy default value should be FAIL. If someone first uses this component and doesn't have create queue permission, this will be more clearly stated in this context.

[tomazfernandes]

And also about the default value, currently both SqsTemplate and SqsContainerOptions are defined as default QueueNotFoundStrategy to CREATE value. To avoid making a change about this, I keep the default value here.

Yup, my suggestion is we do not define a default for autoconfiguration. If the user sets a value we set it, otherwise we don't do anything. This way whatever is the default set for either the Template or Container is respected.

Makes sense?

I think QueueNotFoundStrategy default value should be FAIL

I see, the idea is to facilitate development time which is common, so users don't need to add logic to create queues when targeting e.g. LocalStack, or even AWS itself in a dev environment.

Maybe we can improve the error thrown in this case to make it more clear - let me know if you have any suggestion.

Thanks!

[maxjiang153]

Yup, my suggestion is we do not define a default for autoconfiguration

Yes, I can remove the default value for autoconfiguration. If I remove the CREATE default strategy, the component's default behavior will still be CREATE. So that's the reason I keep this default value to make it clearer. So I wonder if this is necessary or if I should just leave it here.

Maybe we can improve the error thrown in this case to make it more clear - let me know if you have any suggestion.

I agree. Maybe we can add a log when trying to create a new queue?  If the strategy is CREATE and the user doesn't have create queue permissions, they will know why to throw a create queue permissions error while they just want to receive or send a message to the queue.