Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve Superset on EKS doc #530

Merged
merged 15 commits into from
May 21, 2024
Merged

docs: Improve Superset on EKS doc #530

merged 15 commits into from
May 21, 2024

Conversation

sguruvar
Copy link
Contributor

What does this PR do?

馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

superset on EKS changes

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 changed the title superset on EKS changes docs: Improve Superset on EKS doc May 14, 2024
Copy link
Collaborator

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sguruvar thanks for the PR! Please fix the codespell errors. Also, in future, please run pre-commit run -a in your local workstation to avoid these kinds of errors.

@vara-bonthu
Copy link
Contributor

@sguruvar Checkout the spelling suggestions and update the PR.

@sguruvar
Copy link
Contributor Author

@sguruvar thanks for the PR! Please fix the codespell errors. Also, in future, please run pre-commit run -a in your local workstation to avoid these kinds of errors.

Fixed the codespell errors

@sguruvar
Copy link
Contributor Author

@sguruvar Checkout the spelling suggestions and update the PR.

done

@askulkarni2
Copy link
Collaborator

@sguruvar thanks for the PR! Please fix the codespell errors. Also, in future, please run pre-commit run -a in your local workstation to avoid these kinds of errors.

Fixed the codespell errors

Still seeing some pre-commit errors.

@vara-bonthu
Copy link
Contributor

Looks like pre-commit issues are related to Spark Streaming PR. This looks good to me.

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vara-bonthu vara-bonthu merged commit e711af4 into awslabs:main May 21, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants