Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[replay] Fix get secrets from AWS Secrets Manager #679

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattiabertorello
Copy link

When the secret id is selected, the code throws an expectation on the None value.

Make the DbUser and DbPassword available also when selecting the password from the AWS Secrets manager.

Error:

[INFO] 2023-04-11 15:22:25 Fetching secrets from: redshift_simple_replay_admin_credentials
Traceback (most recent call last):
  File "/home/ssm-user/amazon-redshift-utils/src/SimpleReplay/replay.py", line 1988, in <module>
    main()
  File "/home/ssm-user/amazon-redshift-utils/src/SimpleReplay/replay.py", line 1844, in main
    get_connection_credentials(connection_logs[0].username, database=connection_logs[0].database_name, max_attempts=1)
  File "/home/ssm-user/amazon-redshift-utils/src/SimpleReplay/replay.py", line 1450, in get_connection_credentials
    db_user.split(":")[1] if ":" in db_user else db_user,
TypeError: argument of type 'NoneType' is not iterable

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

When the secret id is selected, the code throws an expectation on the None value.

Make the DbUser and DbPassword available also when selecting the password from the AWS Secrets manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant