example(bindings): add async ConfigResolver #4477
Open
+136
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
approved these changes
May 23, 2024
Comment on lines
+84
to
+86
| // let config_resolver = ConfigResolver::new(self.server_config(animal)); | ||
| // ``` | ||
| // because the compiler will complain that `&self` doesn't live long enough. |
There was a problem hiding this comment.
Just wondering: this doesn't work because ConfigResolver::new doesn't own self, right? Like, passing animal should be fine here because it's moved?
I'm curious if there are other ways to do this besides async move? Like, could a struct itself implement 'static + Send + Sync + Future<Output = Result<Config, Error>>> or something so that ConfigResolver::new could own the whole thing? Not sure if that question makes any sense.
| AsyncAnimalConfigResolver { cert_directory } | ||
| } | ||
|
|
||
| // This method will lookup the appropriate certificates and read them from disc |
There was a problem hiding this comment.
nit
Suggested change
| // This method will lookup the appropriate certificates and read them from disc | |
| // This method will lookup the appropriate certificates and read them from disk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds an example showing how to use the async ConfigResolver.
Call-outs:
I haven't decided whether this should be a self contained server, or whether it should just be two separate resolver's that can be used. I think I'm leaning towards the latter.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.