Make ctest always print output on failure #4052
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
commented
Jun 13, 2023
Comment on lines
-109
to
+110
| echo "Running... ctest --no-tests=error --output-on-failure --verbose -R ^integrationv2_${test}$" | ||
| ctest --no-tests=error --output-on-failure --verbose -R ^integrationv2_${test}$ | ||
| echo "Running... ctest --no-tests=error --verbose -R ^integrationv2_${test}$" | ||
| ctest --no-tests=error --verbose -R ^integrationv2_${test}$ |
There was a problem hiding this comment.
My CMake build change wouldn't actually affect this call to ctest, since I only modified the environment for unit tests. But this call already has "--verbose", which outputs on failure AND on success, so "--output-on-failure" is unnecessary anyway.
Merged
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Address's @jmayclin's comment: #4046 (comment)
Description of changes:
Adds CTEST_OUTPUT_ON_FAILURE=1 to all unit test runs. This will be super helpful since we always want output on failure, but constantly forget to add the option since it's not on by default.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.