fix: Update Grafana controller_runtime_reconcile_errors_total to target a specific controller
#6181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -351,7 +351,7 @@ | |||
| "datasource": { | |||
| "uid": "${datasource}" | |||
| }, | |||
| "definition": "label_values(controller_runtime_reconcile_errors_total, controller)", | |||
| "definition": "label_values(controller_runtime_reconcile_errors_total{job=~\"karpenter\"}, controller)", | |||
There was a problem hiding this comment.
Suggested change
| "definition": "label_values(controller_runtime_reconcile_errors_total{job=~\"karpenter\"}, controller)", | |
| "definition": "label_values(controller_runtime_reconcile_errors_total{controller="$controller"}, controller)", |
This matches what we have for the other controller_runtime_... metrics in this file
| @@ -361,7 +361,7 @@ | |||
| "name": "controller", | |||
| "options": [], | |||
| "query": { | |||
| "query": "label_values(controller_runtime_reconcile_errors_total, controller)", | |||
| "query": "label_values(controller_runtime_reconcile_errors_total{job=~\"karpenter\"}, controller)", | |||
There was a problem hiding this comment.
Suggested change
| "query": "label_values(controller_runtime_reconcile_errors_total{job=~\"karpenter\"}, controller)", | |
| "query": "label_values(controller_runtime_reconcile_errors_total{controller="$controller"}, controller)", |
Same here
jonathan-innis
changed the title
controller_runtime_reconcile_errors_total to target a specific controller
Pull Request Test Coverage Report for Build 9044221514Details
💛 - Coveralls |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6163
Description : add job in dashboard's label_values query to get controller values only from karpenter and not from other addons
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.