Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update karpenter docs around soft affinity behavior #6172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cnmcavoy
Copy link

@cnmcavoy cnmcavoy commented May 9, 2024

Fixes #N/A

Description

Documents Karpenter behavior around soft affinities.

How was this change tested?

Docs only change.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cnmcavoy cnmcavoy requested a review from a team as a code owner May 9, 2024 17:52
@cnmcavoy cnmcavoy requested a review from jmdeal May 9, 2024 17:52
Copy link

netlify bot commented May 9, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 924084e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/664b74310eee3b0008281a6c
😎 Deploy Preview https://deploy-preview-6172--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
@jonathan-innis
Copy link
Contributor

Thanks for the docs contribution @cnmcavoy! Got a few thoughts.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9021368101

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 82.237%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 9020423361: -0.03%
Covered Lines: 5403
Relevant Lines: 6570

💛 - Coveralls

@cnmcavoy cnmcavoy force-pushed the cmcavoy/docs-soft-affinities branch 2 times, most recently from cc3879c to 736bb46 Compare May 10, 2024 18:56
@cnmcavoy cnmcavoy force-pushed the cmcavoy/docs-soft-affinities branch from 6b556ce to 924084e Compare May 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants