feat: support multiple clusterDNS #6117
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
| @@ -119,6 +119,14 @@ func (e EKS) isIPv6() bool { | |||
| if e.KubeletConfig == nil || len(e.KubeletConfig.ClusterDNS) == 0 { | |||
There was a problem hiding this comment.
Bottlerocket and AL2023 also have functionality for this. Can we also add support for this to those AMIFamily as well?
There was a problem hiding this comment.
You mean other AMIs also support we bypass a comma separated DNS IPs in the bootstrap script? I can try add them
| @@ -119,6 +119,14 @@ func (e EKS) isIPv6() bool { | |||
| if e.KubeletConfig == nil || len(e.KubeletConfig.ClusterDNS) == 0 { | |||
| return false | |||
| } | |||
|
|
|||
| ips := strings.Split(e.KubeletConfig.ClusterDNS[0], ",") | |||
There was a problem hiding this comment.
ClusterDNS is already a string slice, can we just use the slice directly? All of these AMIFamilies should have support now for passing all of the DNS entries through
There was a problem hiding this comment.
Ok. you mean we just respect all the clusterDNS strings and convert as a string comma-separated string with all IPs
There was a problem hiding this comment.
Right. Ideally we don't let you do a comma-delimited list in any of the strings for ClusterDNS and you just specify them as separate strings in the structued object.
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Fixes #4934
Description
This change will support us bypass multiple clusterDNS with comma separated IP list and not being treated as IPv6
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.