You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
but in a cluster where other controller metrics have a "controller" label (like aws-load-balancer-controller), the filter does not only include karpenter controllers.
adding the job would allow to avoid getting other "non-karpenter" controllers :
@jonathan-innis I think there is a misunderstanding : I think the issue is not on the metrics (which are using the "controller" variable as they should, like in the one you pointed out like : METRIC{controller=\"$controller\"}) but in how this "controller" variable's values are retrieved : using label_values(controller_runtime_reconcile_errors_total, controller) implies that all the controllers that expose the controller_runtime_reconcile_errors_total metric (karpenter is not the only one, aws-load-balancer-controller is also exposing it for example, and maybe other controllers as it is a quite common metric for a controller) are retrieved and listed in the "controller" variable's values, hence appearing in the drop-down variable filter.
However, the only controllers needed for the karpenter dashboard are karpenter's ones so we have to find a way to select only karpenter's label_values, and using {job="karpenter"} is one way to do.
In some dashboards, (e.g. https://github.com/aws/karpenter-provider-aws/blob/main/website/content/en/preview/getting-started/getting-started-with-karpenter/karpenter-controllers.json#L354C37-L354C78) filters are defined like this :
but in a cluster where other controller metrics have a "controller" label (like
aws-load-balancer-controller
), the filter does not only include karpenter controllers.adding the job would allow to avoid getting other "non-karpenter" controllers :
If confirmed, I'll make a PR to fixit
The text was updated successfully, but these errors were encountered: