Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Memgraph and supply chain notebook #522

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

katarinasupe
Copy link

I created a new PR to add support for the Memgraph database without formatting changes. While fixing this, I fixed a couple of other things I noticed, so it turned out to be a good thing to check it.

I added README to the additional databases folder to show that connecting to Memgraph is achievable via the existing Neo4j setup. But, since it's not intuitive for the users to set a username and password for the neo4j configuration setting, I created MemgraphSection in the configuration and exposed username, password, auth and database configuration flags. I added database section too, because Memgraph released a multitenancy feature in v2.10.

I also updated the README in the root folder accordingly.

Since I added Memgraph as an additional database, I also decided to contribute with a notebook.

I would like to add that I missed local testing instructions to be sure all is alright, but I did test the connection to Memgraph and run queries from the Supply Chain Analysis notebook.

Let me know what I need to do else in order to get this PR merged and I will be more than happy to contribute more.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@katarinasupe katarinasupe marked this pull request as ready for review August 22, 2023 08:14
@katarinasupe
Copy link
Author

Hi @krlawrence and @triggan, let me know if you have more questions regarding this PR :)

@smith-kyle
Copy link

I'm a little late to the party, but I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/aws/graph-notebook/pull/522

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants