add modules tests workflow - IGNORE #1416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamazon
changed the title
avifenesh
reviewed
May 15, 2024
.github/workflows/python-modules.yml
Outdated
| paths: | ||
| - ./python/python/* | ||
| - .github/workflows/python-modules.yml | ||
| - .github/workflows/start-self-hosted-runner/action.yml |
There was a problem hiding this comment.
Why do you want to run it on this action?
.github/workflows/python-modules.yml
Outdated
| @@ -0,0 +1,104 @@ | |||
| name: Python Modules Testing | |||
|
|
|||
| on: | |||
.github/workflows/python-modules.yml
Outdated
| python -m pip install --upgrade pip | ||
| pip install flake8 isort black mypy-protobuf | ||
|
|
||
| - name: Lint with isort |
There was a problem hiding this comment.
Is it not going to activate the lint action anyway?
.github/workflows/python-modules.yml
Outdated
| - name: Build Python wrapper | ||
| uses: ./.github/workflows/build-python-wrapper | ||
| with: | ||
| os: "ubuntu" |
.github/workflows/python-modules.yml
Outdated
| os: "ubuntu" | ||
| target: "x86_64-unknown-linux-gnu" | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
There was a problem hiding this comment.
Same - is it not running on any py pr?
shohamazon
force-pushed
the
modules_ci
branch
15 times, most recently
from
c3b26df
to
3e99fdf
Compare
shohamazon
force-pushed
the
modules_ci
branch
7 times, most recently
from
727ce93
to
fa2b200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.