Add 1.30 Vsphere E2E tests #8136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/XXL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8136 +/- ##
=======================================
Coverage 73.40% 73.40%
=======================================
Files 577 577
Lines 35900 35900
=======================================
Hits 26352 26352
Misses 7882 7882
Partials 1666 1666 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
rahulbabu95
force-pushed
the
1-30/add-e2e-vsphere
branch
from
ab8acef
to
10a7a47
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Add E2E tests for Vsphere provider for new K8s version 1.30.
Description of changes:
Testing (if applicable):
Ran all the 1.30 quick tests against my local branch and these are the results . Out of three failures 2 BR tests fail because of the disk size validation which should be fixed once the templates are fixed in CI. The TestVSphereKubernetes129To130StackedEtcdRedHatUpgrade test failed with
template /SDDC-Datacenter/vm/Templates/kubernetes-1-29-eks-10-redhat is missing tag eksdRelease:kubernetes-1-30-eks-3which can be considered a flake because of a random race condition that happens in our controller when the template in Machine Config is updated but not actually reflected when the validations are being checked on the cluster object. The other TestVSphereKubernetes129To130RedHatUpgrade test passes which ensures that it is not related to any newly added framework function as they are being used by both the tests.Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.