feat: Enable Authorization Code + PKCE flow #4974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now we run Device Code if we are in an ssh workspace - Otherwise we run the Authorization code flow Signed-off-by: Nikolas Komonen <nkomonen@amazon.com>
Since the new OIDC client with Authorization Code flow was not released we had to use a pre-build version. Now that the new client is released we can actually use it. Solution: This commit removes the old temp OIDC client and simply uses our existing one with minor modifications to get things working. Also we were required to update some transitive dependencies which is why there are 'smithy' related dependency changes Signed-off-by: Nikolas Komonen <nkomonen@amazon.com>
hayemaxi
approved these changes
May 13, 2024
Signed-off-by: Nikolas Komonen <nkomonen@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The OIDC client Authorization Code + PKCE has been released
Solution
This commit removes the old temp OIDC client and simply uses
our existing one with minor modifications to get things working.
Also we were required to update some transitive dependencies which
is why there are 'smithy' related dependency changes
We can now close #4917 and #4925 as the changes of this PR were taken from them
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.