fix(codecatalyst): menu command fails after using tree node #4870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The codecatalyst commands:
fail if their menu forms are used AFTER the treenode forms.
Steps to reproduce:
openDevEnv()
.Solution:
Follow the instructions from the
VsCodeCommandArg
docstring:aws-toolkit-vscode/packages/core/src/shared/vscode/commands2.ts
Lines 23 to 41 in 4decdf6
TODO:
Note that the bug does NOT occur if you use the "..." menu command FIRST. It seems like the TreeNode is stored as state on the
CommandResource
; is that actually necessary?License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.