-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reload credentials not working when modified #5185
base: master
Are you sure you want to change the base?
Conversation
@debora-ito @millems Please review, tagging you as changes includes to area that were updated by you recently. Please let me know if approach need to be modified |
@@ -252,7 +253,8 @@ protected SdkClientConfiguration mergeChildDefaults(SdkClientConfiguration confi | |||
* Apply global default configuration | |||
*/ | |||
private SdkClientConfiguration mergeGlobalDefaults(SdkClientConfiguration configuration) { | |||
Supplier<ProfileFile> defaultProfileFileSupplier = new Lazy<>(ProfileFile::defaultProfileFile)::getValue; | |||
Supplier<ProfileFileSupplier> profileFileSupplierSupplier = new Lazy<>(ProfileFileSupplier::defaultSupplier)::getValue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit : can we name this something like profileFileSupplierProvider instead of the double "Supplier" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed the variable
CI build failure seems to be unrelated to the PR, it is failing while setting the aws credentials. Please let me know if any setup or changes required |
@anirudh9391 the CI build is failing in the setup.. please let me know if anything can be done to resolve it |
Based on findings, the secrets apart from GITHUB_TOKEN is not available to PR from forked repository. actions/runner#3039 I don't have access to push the branch to this repository. @anirudh9391 would it be possible to pick these changes & create branch in this repo? |
Yeah I can do that |
ProfileFile's builder expects contentLocation or content to be present. Here, ProfileFile is being used as fallback, ensure it doesn't fail
a66d381
to
fd04bab
Compare
Ensure defaultSupplier is used instead of fixedSupplier in case of defaultProfileFile.
I have updated the some places where
defaultProfileFile
was used along withfixedProfileSupplier
withdefaultSupplier
Motivation and Context
Fixes #4268
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License