s3errormsg: handle none error message #8676
Open
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the returned xml contain empty message `<Message></Message>` this will translated to None type in the parsed var from botocore therefore in the enhance_error_msg checks it will fail to iterate on by the _is_sigv4_error_message and _is_kms_sigv4_error_message functions. Signed-off-by: Seena Fallah <seenafallah@gmail.com>
|
Hi @kdaily - Could you please take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
If the returned xml contains an empty message
<Message></Message>this will be translated to None type in the parsed var from botocore therefore in the enhance_error_msg checks it will fail to iterate on by the _is_sigv4_error_message and _is_kms_sigv4_error_message functions.