New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eks): add tag update support for eks cluster #30123
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
packages/@aws-cdk/custom-resource-handlers/lib/aws-eks/cluster-resource-handler/cluster.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/custom-resource-handlers/lib/aws-eks/cluster-resource-handler/cluster.ts
Show resolved
Hide resolved
packages/@aws-cdk/custom-resource-handlers/lib/aws-eks/cluster-resource-handler/cluster.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mrlikl , Thank you for your contribution, left some comments for your inputs.
@shikha372 I have made the proposed changes, please take a look |
packages/@aws-cdk/custom-resource-handlers/test/aws-eks/cluster-resource-provider.test.ts
Show resolved
Hide resolved
vpc, | ||
...getClusterVersionConfig(this, eks.KubernetesVersion.V1_29), | ||
defaultCapacity: 0, | ||
tags: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are we verifying the tag update scenario here ? To explain a bit, was looking for something like once a cluster is created, if we add new props like tag it will trigger the cluster update, using this integ test so that we can verify it is working as expected.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you @mrlikl full coverage with unit tests now :)... wdyt about integ test , just last step of verification to confirm that API is working as expected |
Issue # (if applicable)
Closes #19388
Reason for this change
Adding tag/untag for eks cluster post its creation
Description of changes
Added API calls tagResource and untagResource in Cluster resource handler to handle tag changes
Description of how you validated changes
Have tested the changes by first deploying a cluster with below config:
TestCase - 1 Update to add one more tag
Logs -
TestCase2 - Add, update and remove at the same time
TestCase - 3 Remove all tags
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license