Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): updating helm chart in eks integ test #30100

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented May 8, 2024

Issue # (if applicable)

Closes #.

Reason for this change

This PR fixes failing integration test introduced in #22254.

Description of changes

Modified the chart to be another aws-cli chart so that resources doesn't conflict with installation in same cluster or namespace.

Description of how you validated changes

Ran failing EKS integration test on local

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label May 8, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 8, 2024 03:01
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 8, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@shikha372 shikha372 changed the title (fix): updating helm chart in eks integ test (fix:) updating helm chart in eks integ test May 8, 2024
@shikha372 shikha372 changed the title (fix:) updating helm chart in eks integ test fix(eks): updating helm chart in eks integ test May 8, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f7324d6
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants