Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codepipeline): auto rollback for pipeline #30085

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented May 7, 2024

WIP: waiting for CFn and the L1 props. see #30083 (comment).

I'm also wondering if we should provide the property as per CFn or have a boolean type like a autoRollback. I think customizing it for CDK is a good design, but given the recent CodePipeline trend and its CFn structure, there may be extensions to this in the future. (I've pushed a commit to add a property with the same structure as CFn simply for the record now.)

Issue # (if applicable)

Closes #30083.

Reason for this change

https://aws.amazon.com/jp/about-aws/whats-new/2024/04/aws-codepipeline-stage-level-manual-automated-rollback/

https://docs.aws.amazon.com/codepipeline/latest/userguide/stage-rollback-auto.html

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-stagedeclaration.html

https://docs.aws.amazon.com/codepipeline/latest/APIReference/API_StageDeclaration.html

Description of changes

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels May 7, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 7, 2024 08:09
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label May 7, 2024
@go-to-k go-to-k changed the title feat(codepipeline): auto rolback for pipeline feat(codepipeline): auto rollback for pipeline May 7, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5de5481
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_codepipeline: Rollbacks for CodePipelines
2 participants