Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_codepipeline: Rollbacks for CodePipelines #30083

Open
2 tasks
jaydm26 opened this issue May 7, 2024 · 3 comments · May be fixed by #30085
Open
2 tasks

aws_codepipeline: Rollbacks for CodePipelines #30083

jaydm26 opened this issue May 7, 2024 · 3 comments · May be fixed by #30085
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2

Comments

@jaydm26
Copy link

jaydm26 commented May 7, 2024

Describe the feature

AWS introduced Rollbacks for Stages in CodePipeline. This feature currently seems to be missing in CodePipelines.

https://docs.aws.amazon.com/codepipeline/latest/userguide/stage-rollback.html

Use Case

This feature would allow me to enable automatic rollbacks upon failure directly through CDK instead of manually updating the pipeline to rollback the stage upon failure.

Proposed Solution

# pipeline: codepipeline.Pipeline

pipeline.add_stage(
  placement=None, 
  stage_name, 
  actions=None, 
  transition_disabled_reason=None, 
  transition_to_enabled=None,
  auto_rollback = True # Boolean that determines if the stage should be rolled back upon failure
)

I think there needs to be changes in the L1 object as well, but I am not well-versed with CDK to know the exact changes.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.140.0

Environment details (OS name and version, etc.)

MacOS Sonoma 14.4.1, Python 3.11.7
@jaydm26 jaydm26 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 7, 2024
@jaydm26 jaydm26 changed the title aws_codepipelines: Rollbacks for CodePipelines aws_codepipeline: Rollbacks for CodePipelines May 7, 2024
@github-actions github-actions bot added the @aws-cdk/aws-codepipeline Related to AWS CodePipeline label May 7, 2024
@go-to-k
Copy link
Contributor

go-to-k commented May 7, 2024

I would like to address this issue.

However, the CodePipeline API has this feature, but CloudFormation does not yet. So we are waiting for the CloudFormation property. (However, the user guide already describes the feature on CloudFormation...)

@go-to-k go-to-k linked a pull request May 7, 2024 that will close this issue
Draft
1 task
@jaydm26
Copy link
Author

jaydm26 commented May 7, 2024

Do we have a timeline on by when CloudFormation will be updated? Otherwise, I am happy to raise an issue with https://github.com/cdklabs/awscdk-service-spec

@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 7, 2024
@khushail
Copy link
Contributor

khushail commented May 7, 2024

Hi @jaydm26 ,thanks for requesting this feature. As correctly mentioned by @go-to-k , this is not currently provided by cloudformation. However you could add this feature to Cloudformation coverage roadmap and help in prioritizing this by upvotes.

@khushail khushail added p2 effort/small Small work item – less than a day of effort effort/medium Medium work item – several days of effort needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. effort/small Small work item – less than a day of effort labels May 7, 2024
@jaydm26 jaydm26 mentioned this issue May 8, 2024
Open
This was referenced May 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codepipeline): auto rollback for pipeline go-to-k/aws-cdk
3 participants
@go-to-k @jaydm26 @khushail