Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(network-load-balanced-fargate-service): (Add support for creating load balancer with IPv6 support) #29614

Closed
2 tasks
vishnu0179 opened this issue Mar 26, 2024 · 3 comments · Fixed by #30069
Closed
2 tasks

(network-load-balanced-fargate-service): (Add support for creating load balancer with IPv6 support) #29614

vishnu0179 opened this issue Mar 26, 2024 · 3 comments · Fixed by #30069
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@vishnu0179
Copy link

Describe the feature

Today, if i want to use network-load-balanced-fargate-service construct for creating a fargate service with network loadbalancer attached, we dont have an option to enable IPv6 on Network Loadbalancer. There is no corresponding prop available for the users of this construct to opt for IPv6 NLB.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ecs-patterns/lib/base/network-load-balanced-service-base.ts#L34

We want an prop ipAddressType to control to enable IPv6 address on our load balancer.

Use Case

Our service has a public network load balancer and our client recommends enabling IPv6 for the calling endpoint.

Proposed Solution

Adding an prop ipAddressType in network-load-balanced-service-base.ts so that clients of this can control enabling of loadbalancer IPv6.

Default would be IpAddressType.IPV4 for backward compatibilty.
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_elasticloadbalancingv2.NetworkLoadBalancer.html

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.14.0

Environment details (OS name and version, etc.)

NA
@vishnu0179 vishnu0179 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 26, 2024
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Mar 26, 2024
@vishnu0179 vishnu0179 changed the title (network-load-balanced-fargate-service): (Add support for creating v6 load balancer) (network-load-balanced-fargate-service): (Add support for creating load balancer with IPv6 support) Mar 26, 2024
@tim-finnigan tim-finnigan self-assigned this Mar 26, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 26, 2024
@tim-finnigan
Copy link

Thanks for the feature request.

@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Mar 26, 2024
@tim-finnigan tim-finnigan removed their assignment Mar 26, 2024
@wafuwafu13
Copy link
Contributor

IPv6 support is also requested in ApplicationLoadBalancedFargateService at #29039 and I'm working on it at #29186 including fix testing.
I'd like to work on NetworkLoadBalancedFargateService after ApplicationLoadBalancedFargateService.

This was referenced Apr 1, 2024
Closed
Closed
Closed
@badmintoncryer badmintoncryer mentioned this issue May 6, 2024
Merged
1 task
mergify bot pushed a commit that referenced this issue May 17, 2024
@badmintoncryer
feat(ecs-patterns): dualstack NLB (#30069)
623cedb 
### Issue # (if applicable)

Closes #29614.

### Reason for this change

Dualstack NLB is not supported in `NetworkLoadBalancedServiceBase`.

### Description of changes

- Add `ipAddressType` to `NetworkLoadBalancedServiceBaseProps`.
  - default value is `IpAddressType.Ipv4`

### Description of how you validated changes

Add both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@mergify mergify bot closed this as completed in #30069 May 17, 2024
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs-patterns): dualstack NLB badmintoncryer/aws-cdk
3 participants
@vishnu0179 @wafuwafu13 @tim-finnigan