Changed the DependsOn value for the RancherELB to PublicGatewayAttach… #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment Creating a stack was failing due to timing of the IGW to VPC attachment and RancherELB being created. Replaced DependsOn value from PublicInternetGateway to PublicGatewayAttachment.
|
hey @razavi32, thank you for taking the time to contribute and the improve this workshop! could you please update the other cloud formation template, with the same update? file is |
…ment Part 2 Per the request of the repo owner/maintainer, updated the rke2-eks-cluster-workshop.yaml file where the RacherELB resource property had the same dependency as the rke2-eks-cluster.yaml.
|
@zackbradys no worries, done. |
zackbradys
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ment
Issue: Creating a stack was failing due to timing of the IGW to VPC attachment and RancherELB being created.
Description of changes: Replaced DependsOn value from PublicInternetGateway to PublicGatewayAttachment to ensure the RancherELB wouldnt fail to create due to a VPC without an IGW.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.