Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update targeted ODCR to show p5 to be reflect current usage #1946

Merged
merged 1 commit into from
May 13, 2024

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Update targeted ODCR to show p5 to be reflect current usage
    • Remove t3 capacity reservations and require reservation ARN be passed in via variable
    • Show usage with NVIDIA GPU instance and EFA which is the common use case today
  • Add pod identity agent - start making it a standard on patterns
  • Split out Helm charts to separate file to allow importing into docs site when necessary
  • Add kubectl output per usual

Motivation and Context

  • While its great to have a pattern that can be deployed and see the reservations, etc. - it did not reflect the current target audience (p4/p5 users with EFA), which led to confusion. This updates the pattern to better reflect what the majority would be using today with capacity allocated in targeted ODCRs (tl;dr - meeting users where they are)

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner May 13, 2024 13:23
@@ -71,18 +70,6 @@ module "eks" {
default = {
instance_types = ["m5.large"]

# Default AMI has only 8GB of storage
block_device_mappings = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not strictly required for this architecture so removing to reduce "noise"

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bryantbiggs bryantbiggs merged commit f11b7ef into main May 13, 2024
5 checks passed
@bryantbiggs bryantbiggs deleted the chore/update-targeted-odcr branch May 13, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants