Allow adding extra grammar scopes as a configuration option #17
Conversation
default50
force-pushed
the
add_extra_grammar_scopes
branch
from
b27e693
to
a076900
Compare
default50
force-pushed
the
add_extra_grammar_scopes
branch
from
a076900
to
5d50b34
Compare
| @@ -108,8 +117,17 @@ module.exports = { | |||
| 'atom-cfn-lint.overrideSpecPath', | |||
| (value) => { this.overrideSpecPath = value } | |||
| ), | |||
| atom.config.observe( | |||
| 'atom-cfn-lint.extraGrammarScopes', | |||
| (value) => { this.extraGrammarScopes = value } | |||
There was a problem hiding this comment.
This will only work when the package is initially loaded. You will need to handle changes in this array in the observe callback here.
Over in linter-eslint we take a slightly different approach where we set the default value of the equivalent config option to be the supported list. This does allow the user to remove supported ones, but as they are only adding them most of the time we haven't had any issues with it.
Note: Removing the contents of the Array and adding the new values isn't the most efficient, but it's super simple and when there are only a few (<10) entries in the Array it isn't exactly a performance bottleneck.
There was a problem hiding this comment.
@default50 are you able to make these changes? If not I can provide some help. Thanks for pull request.
Description of changes:
This commit will add a configuration option that allows the user to enable the linter for other grammar scopes in addition to the default ones.
I'm currently using language-yaml-cloudformation plugin that enables support for CloudFormation YAML syntax and it defines a new grammar scope:
source.yaml.cf. By allowing the addition of the grammar scope it makes this linter work.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.