Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extraction of sheet names and identification of sheets with comments #436

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

heseber
Copy link

@heseber heseber commented Nov 19, 2018

The commits fix two issues:

  1. There was a copy&paste bug for the identification of sheets with comments with the effect that sheets with drawings instead of sheets with comments were set to hasComment=TRUE.
  2. Some xlsm files I wanted to read returned wrong sheets if sheets were requested by sheet names. It turned out that this is due to veryHidden sheets with an empty r:id. Sheet names for such sheets are now ignored.

Some Excel files contain sheet names for veryHidden sheets that do not have any sheet content. Such sheets have an empty r:id. Their sheet names have to be skipped because otherwise there will be a misalignment between sheet names and sheet indeces.
@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #436 into master will increase coverage by 0.05%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   60.23%   60.29%   +0.05%     
==========================================
  Files          30       30              
  Lines        7142     7150       +8     
==========================================
+ Hits         4302     4311       +9     
+ Misses       2840     2839       -1
Impacted Files Coverage Δ
R/wrappers.R 42.7% <100%> (+0.09%) ⬆️
R/readWorkbook.R 83.33% <100%> (+0.23%) ⬆️
R/loadWorkbook.R 69.97% <80%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead0038...8b5e6f9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant