-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: JS for dashboard wide filters #2754
Conversation
Code Climate has analyzed commit ae96ae5 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this into the existing dashboads cards controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a mistake with the last decision to move it into the dashboard_card controller.
The mistake is that we are attaching this controller to elements that don't need to be refreshed (the previous behavior).
So, please let's move this into a card_filters_controller
.
Sorry for the back and forth
This PR has been merged into Please check the release guide for more information. |
This reverts commit 75f76a0.
Description
Add JavaScript for: dashboard-wide filters
Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.