Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: JS for dashboard wide filters #2754

Merged
merged 9 commits into from
May 17, 2024
Merged

Conversation

gabrielgiroe1
Copy link
Collaborator

@gabrielgiroe1 gabrielgiroe1 commented May 8, 2024

Description

Add JavaScript for: dashboard-wide filters

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented May 8, 2024

Code Climate has analyzed commit ae96ae5 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this into the existing dashboads cards controller

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake with the last decision to move it into the dashboard_card controller.

The mistake is that we are attaching this controller to elements that don't need to be refreshed (the previous behavior).

So, please let's move this into a card_filters_controller.

Sorry for the back and forth

@Paul-Bob Paul-Bob changed the title Add cards_controller.js feature: JS for dashboard wide filters May 14, 2024
@gabrielgiroe1 gabrielgiroe1 merged commit 75f76a0 into main May 17, 2024
19 of 20 checks passed
@gabrielgiroe1 gabrielgiroe1 deleted the dashboard-wide-filters branch May 17, 2024 09:42
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@gabrielgiroe1 gabrielgiroe1 restored the dashboard-wide-filters branch May 20, 2024 22:02
gabrielgiroe1 added a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants