Dead processes metrics #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikha1lov
commented
Mar 22, 2024
•
mikha1lov
commented
- Counting processes
- Sending last pack of metrics after app was stopped
mikha1lov
force-pushed
the
main
branch
4 times, most recently
from
61df202
to
4ba99af
Compare
bugrimov
reviewed
Mar 25, 2024
aqueduct/metrics/collect.py
Outdated
| @@ -30,13 +30,15 @@ def __init__(self): | |||
| self.queue_sizes = MetricsItems() | |||
| self.tasks_stats = TasksStats() | |||
| self.memory_usage = MetricsItems() | |||
| self.dead_processes_count = MetricsItems() | |||
There was a problem hiding this comment.
word 'count' in dead_processes_count seems like unnecessary, it will be simplier id you make just self.dead_processes
mikha1lov
force-pushed
the
main
branch
6 times, most recently
from
70b9f08
to
f078814
Compare
bugrimov
reviewed
Apr 12, 2024
bugrimov
reviewed
Apr 12, 2024
aqueduct/metrics/processes.py
Outdated
|
|
||
| def add_dead_process(self): | ||
| self.dead += 1 | ||
| self.running = 0 |
There was a problem hiding this comment.
self.running = 0
looks like a crutch, can we deal without need self.running = 0, maybe we dont need stop metcrics manager when we stoppping flow
bugrimov
reviewed
Apr 12, 2024
| @@ -25,6 +25,7 @@ | |||
| from .metrics.collect import Collector, TasksStats | |||
There was a problem hiding this comment.
Please updade CHANGELOG and version
bugrimov
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.