Merge pull request #54 from cyberlis/METRICS-INTERVAL

Changed default export period to 0.5 to fix metrics gaps

CHANGELOG.md

@@ -1,3 +1,6 @@
+# 1.11.5
+- Changed default export period to 0.5 to fix metrics gaps
+
 # 1.11.4
 - Lower cpu usage in main process
 

aqueduct/metrics/export.py

@@ -31,7 +31,7 @@ def gauge(self, name: str, value: Union[float, int]):
 
 
 class Exporter(ABC):
-    def __init__(self, target: Any, export_period: float = 10., prefix: str = None):
+    def __init__(self, target: Any, export_period: float = 0.5, prefix: str = None):
         self.target = target
         self.export_period = export_period
         if prefix is None:
@@ -46,7 +46,7 @@ def export(self, metrics: AqueductMetricsStorage):
 
 class ToStatsDMetricsExporter(Exporter):
     """Translates aqueduct metrics to statsd metrics format."""
-    def __init__(self, target: StatsDBuffer, export_period: float = 10., prefix: str = None):
+    def __init__(self, target: StatsDBuffer, export_period: float = 0.5, prefix: str = None):
         super().__init__(target, export_period, prefix)
 
     def export(self, metrics: AqueductMetricsStorage):

setup.py

@@ -22,7 +22,7 @@
 setup(
     name='aqueduct',
     packages=find_packages(),
-    version='1.11.4',
+    version='1.11.5',
     license='MIT',
     license_files='LICENSE.txt',
     author='Data Science SWAT',

tests/unit/test_flow.py

@@ -175,6 +175,7 @@ async def test_start_waiting_for_subproccess_to_start(self, task: Task):
         t1 = time.time()
 
         assert t1 - t0 == pytest.approx(slowest_handler.start_time, 0.5)
+        await flow.stop()
 
     async def test_start_waiting_timeout(self, task: Task):
         """flow.start(timeout) should raise FlowError when starting_timeout expired."""
@@ -189,6 +190,7 @@ async def test_start_waiting_timeout(self, task: Task):
         t1 = time.time()
 
         assert t1 - t0 == pytest.approx(timeout, 0.5)
+        await flow.stop()
 
     async def test_process_set_result(self, simple_flow: Flow, task: Task):
         assert task.result is None