Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for DefaultProceessController #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gopito
Copy link

@gopito gopito commented Mar 15, 2022

When I use DefaultProcessController with applesimutils
var processController = DefaultProcessController( subprocess: Subprocess(arguments: [ "/usr/local/bin/applesimutils", "-id", "EB6808EB-9181-45EF-A31F-668EE42456C0", "-b", "my.bundle.id", "-sp", "notifications=YES, photos=YES, camera=YES, userTracking=NO, microphone=YES, location=always" ]) )

I get exit code 255. I find out that it is because of environment variables that we pass to process. Even default empty array [:] leads to error exit code.

Signed-off-by: Anton Smolianin <a.smolianin@corp.mail.ru>
@beefon
Copy link
Collaborator

beefon commented Mar 17, 2022

We've discussed this internally. It is not clear why this can solve any possible problem with that applesim. I think it worth debugging it instead of making a change into CLT.
Besides, setting subprocess.environment to .current should do exactly the same thing you did in this PR.
Also, this change disallows passing an empty env into subprocess.

Signed-off-by: Anton Smolianin <a.smolianin@corp.mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants