New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): provide modular images for openadkit planning simulator visualizer #4673
base: main
Are you sure you want to change the base?
feat(docker): provide modular images for openadkit planning simulator visualizer #4673
Conversation
@oguzkaganozt It is good PR but quite a big changes to review it. To streamline the review process, please minimize the amount of revisions per PR and break it up into multiple PRs. |
Thank you for the review @youtalk. You're right on big PR changes but since this PR includes many tightly-related changes I though that it will be more easier to review in all-in-one PR. For the multi-stage build we are already utilizing it in the monolithic images of Autoware |
@oguzkaganozt Could you make modification to the documentation accordingly as well? I think the path for run scripts and build scripts must be changed on this page. |
I think the renaming refactoring and multi-stage build PRs should be done separately. If we do the renaming first, the diff would be smaller. |
9f002d5
to
6199c9c
Compare
@mitsudome-r we don't need to update any documentation for this PR anymore, as right now it is only adding |
d998572
to
69b7859
Compare
I know the changes look like a lot, but as I said this work is tightly coupled and includes the all work that previously demonstrated at the last CES. Creating separate PRs would be ideal but the time timeline is tight for these features to make users to replicate the last demo. |
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
363229f
to
cbc9263
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to review it, but the diff is too large to write review comments easily. Although it is divided into multiple images, it looks very wasteful because the same vcs import
and rosdep install
are repeated in various Dockerfiles. Also, the Dockerfiles other than the simulator
are almost the same in content.
@youtalk at this stage of development my main focus was to just introduce these 3 different modules with demonstration of planning scenario. You're right that there are not much of diff between these dockerfiles but in the near future after defining the Refining of each module's dockerfiles will be done on top of that, also we can leverage |
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Removed the upload artifacts section from the workflow because of the disk space after resolving the issue we can re-enable them. @youtalk @mitsudome-r |
#4771 reduces the image size. Please merge the latest main branch and check the CI again. |
@oguzkaganozt You were saying the opposite #4738 (comment). So I think we can't remove the
|
Description
Provide modular planning, simulator and visualizer containers to enable easier development and deployment of Autoware functionalities with distinct needs.
autoware
package and, openadkit images intoautoware-openadk
packageplanning, simulator, visualizer
container imagesdocker-compose
file for running autoware with multiple images easilyDetailed information can be found at the below related issue.
Related links
#4538
Tests performed
docker build action: https://github.com/autowarefoundation/autoware/actions/runs/9177235488
New docker images are thoroughly tested in a fresh environment.
Notes for reviewers
Interface changes
N/A as it will only introduce new modular container images.
Effects on system behavior
N/A to bare-metal setups, but it will provide new modular deployment scheme.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.