Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datastore metadata function and test #782

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sctse999
Copy link
Contributor

@sctse999 sctse999 commented Feb 3, 2021

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #782 (8caa10b) into dev (a35ef33) will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #782      +/-   ##
==========================================
+ Coverage   29.46%   29.49%   +0.02%     
==========================================
  Files          66       66              
  Lines        7985     7988       +3     
  Branches      839      839              
==========================================
+ Hits         2353     2356       +3     
- Misses       5512     5513       +1     
+ Partials      120      119       -1     
Impacted Files Coverage Δ
donkeycar/parts/datastore_v2.py 92.30% <33.33%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a35ef33...8caa10b. Read the comment docs.

Copy link
Collaborator

@tikurahul tikurahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the intended usecase ?

@sctse999
Copy link
Contributor Author

sctse999 commented Feb 3, 2021

E.g. allowing user to put remarks on a dataset (we allow this on the app)

@tikurahul
Copy link
Collaborator

Lets hold off on making this change. There are a few things I want to change before we land this.

@sctse999
Copy link
Contributor Author

Just wondering when this could get merged?

@tikurahul
Copy link
Collaborator

Actually i thought more about this, and I don't want to add this feature to the Tub itself. This is because metadata is already a very overloaded term.

You can keep this data in a separate file, and correlate it with the session_id.

BillyCheung10botics pushed a commit to robocarstore/donkeycar that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants