added speed return for simulator in dgym.py #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this work with the official simulator? |
|
Absolutely. No simulator changes were required. It was already implemented in Unity just not in the DonkeyGymEnv (which it is now). |
|
The Travis failure is w.r.t the training convergence which we have already scheduled to take out of travis, everything else passes. Looks good to me otherwise. |
|
Great! Thanks @DocGarbanzo 👍 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as stated.
Does have changes that stop compatibility with other manage.py templates. Going forward - everyone should use simulator.py template to ensure all new simulator changes are implemented and working.