Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StopSign and Cone Detection #1131

Open
wants to merge 3 commits into
base: tf_2_9
Choose a base branch
from
Open

StopSign and Cone Detection #1131

wants to merge 3 commits into from

Conversation

cfox570
Copy link
Contributor

@cfox570 cfox570 commented May 19, 2023

New parts to control Donkeycar to stop at Stop Signs and swerve around traffic cones.

New parts to control Donkeycar to stop at Stop Signs and swerve around traffic cones.
Copy link
Contributor

@DocGarbanzo DocGarbanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an interesting addition to the project. Do you have a video, or similar, where this can be seen in action? I only have minor comments to the code.

donkeycar/parts/object_detector/conemodel.tflite Outdated Show resolved Hide resolved
from tflite_support.task import processor
from tflite_support.task import vision

'''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like commented code, can you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

donkeycar/parts/object_detector/detector.py Outdated Show resolved Hide resolved
donkeycar/parts/object_detector/od_protocol.py Outdated Show resolved Hide resolved
donkeycar/parts/object_detector/od_protocol.py Outdated Show resolved Hide resolved
donkeycar/parts/object_detector/od_protocol.py Outdated Show resolved Hide resolved
donkeycar/parts/object_detector/od_protocol.py Outdated Show resolved Hide resolved
Removed extraneous code and unnecessary comments
@cfox570
Copy link
Contributor Author

cfox570 commented Jul 6, 2023

This looks like an interesting addition to the project. Do you have a video, or similar, where this can be seen in action? I only have minor comments to the code.

Working on making a video. Expect to finish by Sunday.

Remove the large files.
@cfox570
Copy link
Contributor Author

cfox570 commented Jul 6, 2023

I am not clear why the MacOS.yml failed.

Copy link
Contributor

@Ezward Ezward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to need changes to documentation for this. We have some docs on the current stop sign detector Stop Sign Detection; those will have to be changed. Can you open a parallel PR in the docs repository for the documentation changes? https://github.com/autorope/donkeydocs. For an example of what we are doing for docs in new features, see http://docs.donkeycar.com/guide/path_follow/path_follow/ and http://docs.donkeycar.com/guide/computer_vision/computer_vision/

@cfox570
Copy link
Contributor Author

cfox570 commented Jul 7, 2023

I created a pull request for this part. See autorope/donkeydocs#51

@cfox570
Copy link
Contributor Author

cfox570 commented Jul 9, 2023

where this can be seen in action?

I created two videos.... Stop Sign detection and Traffic Cone avoidance.

And I added the video to the DonkeyDocs pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants