Dgym refactor #1107
Draft
Dgym refactor #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocGarbanzo
reviewed
Mar 7, 2023
There was a problem hiding this comment.
This is a great change improving the interface to the donkey gym. A couple of comments how to improve the return values from the gym to stay in vectors instead of components.
We should also put gym into the conda yaml install and setup.py. It's good that you have a test, we should make sure this can be run also in the CI.
- output vectors instead of single components
Maximellerbach
commented
Mar 7, 2023
Maximellerbach
commented
Mar 8, 2023
setup.py
Outdated
| 'imgaug' | ||
| 'imgaug', | ||
| 'gym', | ||
| 'gym-donkeycar @ git+ssh://git@github.com/tawnkramer/gym-donkeycar.git@master#egg=gym-donkeycar', |
There was a problem hiding this comment.
This doesn't work in the CI, need to fix
There was a problem hiding this comment.
Can you try removing the trailing @master... and just put:
'gym-donkeycar @ git+ssh://git@github.com/tawnkramer/gym-donkeycar.git`
DocGarbanzo
reviewed
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.