YAML - On load, convert all scalar types to strings #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will use the YAML SafeConstructor to safely load YAML data and auto-convert scalar types to strings to provide a consistent experience with AutoPkg's current behavior and data type expectations.
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will use the YAML SafeConstructor to safely load YAML data and auto-convert scalar types to strings to provide a consistent experience with AutoPkg's current behavior and data type expectations.
Basically this change will perform a very similar result as what I proposed in #911, however, it will only convert scalar types while preserving non-scalar types. Doing it this way should prevent any issues with current recipes.
I think, short term, this is a better option that what I proposed in #911.
Long term, I think updating the do_variable_substitution function (or update_data function as whole) would create the best experience as suggested by @jgstew here. This would give recipe writers more flexibility and allow more data types to be passed through AutoPkg steps.