-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second Batch of Submissions Tests #2132
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThis update focuses on enhancing the submissions handling in the application, specifically improving clarity, consistency, and testing around student submissions. It introduces clearer naming conventions, extends testing for submission-related actions across different user roles, and adds functionality for downloading and managing submissions. This comprehensive approach aims to streamline submission workflows and ensure robustness through detailed testing scenarios. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
shared_examples "destroyConfirm_failure" do | ||
it "renders with success" do | ||
sign_in(user) | ||
get :destroyConfirm, params: { course_name: @course.name, assessment_name: @assessment.name, | ||
id: get_first_submission_by_assessment(@assessment).id } | ||
expect(response).not_to be_successful | ||
expect(response.body).not_to match(/Deleting a student's submission/m) | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shared example destroyConfirm_failure
is mislabeled based on its content. The description within the it
block states "renders with success," which contradicts the name of the shared example suggesting a failure scenario. This could lead to confusion when reading the test suite.
Consider renaming the shared example to accurately reflect the scenario it tests, such as destroyConfirm_success
if the intention is to test a successful rendering, or updating the test content to align with a failure scenario if that was the original intent.
Description
create_course_no_submissions_hash
to have a test course with no submissionsHow Has This Been Tested?
Run the tests, see that they pass
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting