cpp-20 lambda fix #256
Open
cpp-20 lambda fix #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just for reference: see here for the documentation of lambda-captures: cppreference.com |
PaulXiCao
suggested changes
Dec 22, 2022
| @@ -1096,7 +1096,7 @@ struct BooleanExpr | |||
|
|
|||
| void update() { val = expr(); } | |||
|
|
|||
| auto operator! () const { return BooleanExpr([=]() { return !(expr()); }); } | |||
| auto operator! () const { return BooleanExpr([=, this]() { return !(expr()); }); } | |||
There was a problem hiding this comment.
It is enough to capture this, i.e. [this](){ return ...}. For C++17 it is even not allowed to specify both. It is a bit hidden but specified on cppreference.
|
If C++20 is a goal then we might should search for similar things. A simple regex might be enough at first or parse the code base with libclang? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring cpp-20 compiler standard compatibility by fixing reference in lambda function.