Fixed long wait bug when scaling up a cluster with the -g flag. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the -g flag to scale up a cluster, the wait for all pods to be up would never succeed and always reach the timeout when there is more than one Marathon application with the same cluster name. Note that this bug was actually not leading to an error since the _spin() would return eventually (even if the condition is not met), but it would wait for the duration of the specified timeout for nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the -g flag to scale up a cluster, the wait for all pods to
be up would never succeed and always reach the timeout when there is
more than one Marathon application with the same cluster name. Note that
this bug was actually not leading to an error since the _spin() would
return eventually (even if the condition is not met), but it would wait
for the duration of the specified timeout for nothing.