Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc doc fix + make clusters argument required #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UncleBarney
Copy link

  1. Fix on command help doc.
  2. Make clusters argument as required.

@opaugam
Copy link

opaugam commented Sep 9, 2015

A few remarks : all tools are defaulted to match '*' by design (especially log, grep and the like). You don't want to force the user to specify a regex when he or she wants to list the whole thing. What you want though is to add an extra confirmation switch to the ping tool, exactly the same way it's done for 'kill'. I suggest to rollback your changes and just mimic the logic from kill.py into ping.py.

@UncleBarney
Copy link
Author

You are absolutely right, your plan makes more sense, I will update this PR.

@opaugam
Copy link

opaugam commented Sep 9, 2015

thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants