Fix missing cached database when storage is low #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cached database is stored in a temporary folder which could be cleared at any time (https://pub.dev/documentation/path_provider/latest/path_provider/getTemporaryDirectory.html). Unfortunately sometimes the cached database is no longer available when the app is opened in offline mode. This commit changed the directory for the cached database to the Application Support Directory (https://pub.dev/documentation/path_provider/latest/path_provider/getApplicationSupportDirectory.html). The Application Documents Directory is not used because this directory is already used for local databases and queried when opening local databases. Since the cached version of databases should not be selected manually the Application Support Directory was chosen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cached database is stored in a temporary folder which could be cleared at any time
(https://pub.dev/documentation/path_provider/latest/path_provider/getTemporaryDirectory.html). Unfortunately sometimes the cached database is no longer available when the app is opened in offline mode.
This PR changes the directory for the cached database to the Application Support Directory
(https://pub.dev/documentation/path_provider/latest/path_provider/getApplicationSupportDirectory.html).
The Application Documents Directory is not used because this directory is already used for local databases and queried when opening local databases.
Since the cached version of databases should not be selected manually the Application Support Directory was chosen.
This PR closes PR #340 which is no longer needed.