Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working on adding Apple as an authentication provider into Authomatic.
To do so I had to introduce 2 changes in the
OAuth2
base class:PyJWT
as a requirement of the package.response_mode
param, so I add a dummy method that returns nothing in the base OAuth2 class and then the method that returns what Apple requires in its own baseclass.I don't exactly know whether Apple's implementation is a fully OAuth2 compliant implementation, so I am OK if this PR is completely disregarded. I just wanted to let you know about these changes and discuss them before integrating into Authomatic.