Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Added an adapter for FastAPI"" #229

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jensens
Copy link
Member

@jensens jensens commented Jun 9, 2023

Original: #216
Reverts #228

@jensens
Copy link
Member Author

jensens commented Jun 9, 2023

looks like we need this PR fixed first authomatic/liveandletdie#15

@mrichar1
Copy link
Member

Some minor updates to the fastapi functional_test app to get it working. This works when run manually via uvicorn --app-dir authomatic/examples/fastapi/functional_test/ main:app --host 127.0.0.1 --port 443 --reload which matches what test_providers calls.

However uvicorn is running this with scheme http which causes everything to still fail. Looking at the config, it appears we need to pass in a keyfile and certfile with the command-line params --ssl-keyfile TEXT --ssl-certfile TEXT.

Currently the liveandletdie code generates temporary certs for Pyramid (WSGISimpleServer) but the code relies on generating and using them in the same place inside a with tempdir block. Need a better way to handle this for fastapi when the code is returning the command to be run, and control of the tempdir would be 'lost'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants