Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error status with logging.ERROR to detect access() errors #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muravjov
Copy link
Contributor

I noted, that AuthorizationProvider.access() does not tread bad answer (!= 200 status) as error.
This patch fixes it.

@muravjov
Copy link
Contributor Author

The example: Github provider requires User-Agent or it 403-is.

Copy link
Member

@mrichar1 mrichar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

I would suggest that it is better to test for the 'error' class of response codes (4xx) rather than a specific success code (200) or we might hit false positives if APIs return other 2xx codes (204 seems a likely candidate, for example).

@mrichar1
Copy link
Member

After several years of inactivity, authomatic is now under community management, and we have just released a new stable version (1.0.0).

We are now reviewing all issues and PRs and hoping to begin work to solve as many of these as possible.

We are keen to find out which issues still apply, and which PRs are still required/are likely to merge cleanly into the current code. We are aiming to review them all, but any help with prioritisation would be very useful!

If you are still interested in having this issue/PR resolved, or are able to help us work on it, please reply to this message. That way we know which issues are most important to the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue-Management
  
New: Needs Check
Development

Successfully merging this pull request may close these issues.

None yet

2 participants