added oauth2 login using proxy setting #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrichar1
reviewed
May 29, 2017
There was a problem hiding this comment.
Couple of minor things:
-
this PR is overriding the
typebuiltin - please either rename this variable, or if it is never to be used, replace with_ -
the code can be simplified by using the default option for
os.environ.get, e.g.:os.environ.get('http_proxy', host)
This then removes the need for the not None if tests.
- I'm also not sure of the reason for the change of
request_pathtourlin theconnection.requestmethod call?
This was referenced May 30, 2017
jensens
requested changes
May 31, 2017
authomatic/providers/__init__.py
Outdated
| @@ -382,14 +383,26 @@ def _fetch(self, url, method='GET', params=None, headers=None, body='', max_redi | |||
| self._log(logging.DEBUG, ' \u251C\u2500 params: {0}'.format(params)) | |||
| self._log(logging.DEBUG, ' \u2514\u2500 headers: {0}'.format(headers)) | |||
|
|
|||
| http_proxy = os.environ.get('http_proxy') | |||
| https_proxy= os.environ.get('https_proxy') | |||
| type,https_host=https_proxy.split('//') | |||
There was a problem hiding this comment.
type is a built_in, to avoid conflicts in names use type_ as it's done often in Python.
Also add a space after the , (pep8)
| connection = http_client.HTTPConnection(http_host) | ||
| connection.set_tunnel(host) | ||
| else: | ||
| connection = http_client.HTTPConnection(host) |
There was a problem hiding this comment.
DRY - this can be written simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #71 #105 .
Added support for Authomatic to work behind a proxy. It looks for http_proxy / https_proxy environment variables and uses them in the connection calls.